feat: lock board #3955

brandstetterm · 2024-03-08T09:27:19Z

Description

Frontend changes related to the locking of a board. If a board is locked, participants (without moderation permissions) are no longer able to create, update and delete notes, dispatch board reactions, add or remove reactions to a note, add or remove votes to a note. Therefore, there have been some changes in the frontend (e.g. gray out buttons, hide buttons, etc.). A detailed list of the changes can be found below.

Closes #3538

Changelog

NoteInput: Disable textarea, add lock icon, gray out plus icon
StackView: Disable textarea to edit note content, hide delete and unstack buttons
Action Bars: Disable button to dispatch board reactions, automatically close board reactions menu if board gets locked
Notes: Hide button to open reactions dropdown, disable button to remove note reactions, hide button to add a vote and disable button to remove a vote
Update several tests and snapshots

Future tasks

Implement notifications manager and dispatch notification that board is locked on join

Visual changes

editing from redux store

input

octomind-dev · 2024-03-11T08:01:03Z

🐙 Octomind

Test Report: 10/13 successful.

description	status	details
change avatar	Passed ✅	click
check Privacy Policy	Passed ✅	click
check terms & conditions	Passed ✅	click
close cookie banner - front page	Passed ✅	click
close cookie banner - sign-in	Passed ✅	click
create and delete board columns	Failed ❌	click
create_and_delete_notes_and_actions_v2	Failed ❌	click
create lean coffee board	Passed ✅	click
edit_notes_and_actions_v5	Failed ❌	click
get started	Passed ✅	click
share_session	Passed ✅	click
sign-in	Passed ✅	click
test all ways to open the setup flow	Passed ✅	click

commit sha: 2fffed9

moderator

octomind-dev · 2024-03-11T10:09:29Z

🐙 Octomind

Test Report: 12/13 successful.

description	status	details
change avatar	Passed ✅	click
check Privacy Policy	Passed ✅	click
check terms & conditions	Passed ✅	click
close cookie banner - front page	Passed ✅	click
close cookie banner - sign-in	Passed ✅	click
create and delete board columns	Passed ✅	click
create_and_delete_notes_and_actions_v2	Passed ✅	click
create lean coffee board	Passed ✅	click
edit_notes_and_actions_v5	Failed ❌	click
get started	Passed ✅	click
share_session	Passed ✅	click
sign-in	Passed ✅	click
test all ways to open the setup flow	Passed ✅	click

commit sha: 7af6b86

octomind-dev · 2024-03-12T12:52:25Z

🐙 Octomind

Test Report: 11/13 successful.

description	status	details
change avatar	Passed ✅	click
check Privacy Policy	Passed ✅	click
check terms & conditions	Passed ✅	click
close cookie banner - front page	Passed ✅	click
close cookie banner - sign-in	Passed ✅	click
create and delete board columns	Passed ✅	click
create_and_delete_notes_and_actions_v2	Passed ✅	click
create lean coffee board	Failed ❌	click
edit_notes_and_actions_v5	Failed ❌	click
get started	Passed ✅	click
share_session	Passed ✅	click
sign-in	Passed ✅	click
test all ways to open the setup flow	Passed ✅	click

commit sha: 7b6091e

octomind-dev · 2024-03-12T13:06:14Z

🐙 Octomind

Test Report: 11/13 successful.

description	status	details
change avatar	Passed ✅	click
check Privacy Policy	Passed ✅	click
check terms & conditions	Passed ✅	click
close cookie banner - front page	Passed ✅	click
close cookie banner - sign-in	Passed ✅	click
create and delete board columns	Passed ✅	click
create_and_delete_notes_and_actions_v2	Passed ✅	click
create lean coffee board	Passed ✅	click
edit_notes_and_actions_v5	Failed ❌	click
get started	Passed ✅	click
share_session	Failed ❌	click
sign-in	Passed ✅	click
test all ways to open the setup flow	Passed ✅	click

commit sha: 315cf92

participants)

octomind-dev · 2024-03-12T13:36:33Z

🐙 Octomind

Test Report: 12/13 successful.

description	status	details
change avatar	Passed ✅	click
check Privacy Policy	Passed ✅	click
check terms & conditions	Passed ✅	click
close cookie banner - front page	Passed ✅	click
close cookie banner - sign-in	Passed ✅	click
create and delete board columns	Passed ✅	click
create_and_delete_notes_and_actions_v2	Passed ✅	click
create lean coffee board	Passed ✅	click
edit_notes_and_actions_v5	Failed ❌	click
get started	Passed ✅	click
share_session	Passed ✅	click
sign-in	Passed ✅	click
test all ways to open the setup flow	Passed ✅	click

commit sha: a18c165

Schwehn42 · 2024-04-27T12:13:19Z

Added a blocked label, because #4104 should be merged before this

brandstetterm · 2024-04-30T17:39:34Z

Thanks for your review @Schwehn42
Since I'm limited in time right now, you can commit the suggested changes yourself if you want 😄

# Conflicts: # src/components/MenuBars/MenuBars.tsx

octomind-dev · 2024-05-06T11:42:50Z

🐙 Octomind

Test Report: 0/14 successful.

description	status	details
About Section Visibility Test	Failed ❌	click
change avatar	Failed ❌	click
check Privacy Policy	Failed ❌	click
check terms & conditions	Failed ❌	click
close cookie banner - front page	Failed ❌	click
close cookie banner - sign-in	Failed ❌	click
create and delete board columns	Failed ❌	click
create_and_delete_notes_and_actions_v2	Failed ❌	click
create lean coffee board	Failed ❌	click
edit_notes_and_actions_v5	Failed ❌	click
get started	Failed ❌	click
share_session	Failed ❌	click
sign-in	Failed ❌	click
test all ways to open the setup flow	Failed ❌	click

commit sha: 34cf2e3

octomind-dev · 2024-05-07T16:29:20Z

🐙 Octomind

Test Report: 0/14 successful.

description	status	details
About Section Visibility Test	Failed ❌	click
change avatar	Failed ❌	click
check Privacy Policy	Failed ❌	click
check terms & conditions	Failed ❌	click
close cookie banner - front page	Failed ❌	click
close cookie banner - sign-in	Failed ❌	click
create and delete board columns	Failed ❌	click
create_and_delete_notes_and_actions_v2	Failed ❌	click
create lean coffee board	Failed ❌	click
edit_notes_and_actions_v5	Failed ❌	click
get started	Failed ❌	click
share_session	Failed ❌	click
sign-in	Failed ❌	click
test all ways to open the setup flow	Failed ❌	click

commit sha: 9f6ba11

This reverts commit db6d354.

# partial revert from b3a6381

This reverts commit 48f2461.

octomind-dev · 2024-05-13T14:58:48Z

🐙 Octomind

Test Report: 0/14 successful.

description	status	details
About Section Visibility Test	Failed ❌	click
change avatar	Failed ❌	click
check Privacy Policy	Failed ❌	click
check terms & conditions	Failed ❌	click
close cookie banner - front page	Failed ❌	click
close cookie banner - sign-in	Failed ❌	click
create and delete board columns	Failed ❌	click
create_and_delete_notes_and_actions_v2	Failed ❌	click
create lean coffee board	Failed ❌	click
edit_notes_and_actions_v5	Failed ❌	click
get started	Failed ❌	click
share_session	Failed ❌	click
sign-in	Failed ❌	click
test all ways to open the setup flow	Failed ❌	click

commit sha: 0ed8a50

octomind-dev · 2024-05-14T10:51:36Z

🐙 Octomind

Test Report: 0/14 successful.

description	status	details
About Section Visibility Test	Failed ❌	click
change avatar	Failed ❌	click
check Privacy Policy	Failed ❌	click
check terms & conditions	Failed ❌	click
close cookie banner - front page	Failed ❌	click
close cookie banner - sign-in	Failed ❌	click
create and delete board columns	Failed ❌	click
create_and_delete_notes_and_actions_v2	Failed ❌	click
create lean coffee board	Failed ❌	click
edit_notes_and_actions_v5	Failed ❌	click
get started	Failed ❌	click
share_session	Failed ❌	click
sign-in	Error 💔	click
test all ways to open the setup flow	Failed ❌	click

commit sha: ffcadc6

octomind-dev · 2024-05-29T12:43:00Z

🐙 Octomind

Test Report: 0/14 successful.

description	status	details
About Section Visibility Test	Failed ❌	click
change avatar	Failed ❌	click
check Privacy Policy	Failed ❌	click
check terms & conditions	Failed ❌	click
close cookie banner - front page	Failed ❌	click
close cookie banner - sign-in	Failed ❌	click
create and delete board columns	Failed ❌	click
create_and_delete_notes_and_actions_v2	Failed ❌	click
create lean coffee board	Failed ❌	click
edit_notes_and_actions_v5	Failed ❌	click
get started	Failed ❌	click
share_session	Failed ❌	click
sign-in	Failed ❌	click
test all ways to open the setup flow	Failed ❌	click

commit sha: f353a3d

github-actions · 2024-05-29T12:51:46Z

The deployment to the dev cluster was successful. You can find the deployment here: https://3955.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images

ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-f353a3d
ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-f353a3d

octomind-dev · 2024-05-29T12:52:16Z

🐙 Octomind

Test Report: 14/14 successful.

description	status	details
About Section Visibility Test	Passed ✅	click
change avatar	Passed ✅	click
check Privacy Policy	Passed ✅	click
check terms & conditions	Passed ✅	click
close cookie banner - front page	Passed ✅	click
close cookie banner - sign-in	Passed ✅	click
create and delete board columns	Passed ✅	click
create_and_delete_notes_and_actions_v2	Passed ✅	click
create lean coffee board	Passed ✅	click
edit_notes_and_actions_v5	Passed ✅	click
get started	Passed ✅	click
share_session	Passed ✅	click
sign-in	Passed ✅	click
test all ways to open the setup flow	Passed ✅	click

commit sha: f353a3d

Schwehn42 · 2024-05-29T15:18:34Z

added feats: #4144 and #4145, ready to review now

brandstetterm added 4 commits March 7, 2024 17:05

Add simple component to lock the board in the quick menu

d57035c

Add allowEditing boolean to board type

039baeb

Set toggle value of lock board component to current value of allow

7196dc1

editing from redux store

Clicking on the lock board button dispatches api request

78b36a4

brandstetterm self-assigned this Mar 8, 2024

brandstetterm and others added 9 commits March 8, 2024 10:31

Merge branch 'main' into mb/lock-board

af1bc6f

Add board settings toggle to change the locking of a board

d876b3b

Add gap between different groups of board settings and change order

578785f

Update snapshots of board settings and header menu

f68d9ed

Translate label of board settings toggle

77d9dc7

Add translated labels to header menu toggle

b5c881f

Update snapshots of header menu and board settings

c4689a9

Change import order of lock board component

15e46ab

Grey out disabled buttons when board is locked and add lock icon to note

9fcd848

input

brandstetterm added 2 commits March 11, 2024 10:51

Disable the moving of notes for participants when the board is locked

b7b3eae

Hide note reactions when board is locked and participant is not

0b7da39

moderator

Resolve merge conflicts

2ff2f67

Merge branch 'main' into mb/lock-board

6e92701

brandstetterm added 3 commits March 12, 2024 14:15

Remove box shadow when noteinput is disabled (only for normal

82805ba

participants)

Only disable the menu bar items when the participant is not moderator

b3a6381

Disable textarea of note for participants

912ad67

brandstetterm added 4 commits March 12, 2024 15:33

Hide note reactions button for participants when board is locked

1d018ce

Disable button to remove own note reaction for non-moderator

c63f550

Gray out plus icon in noteinput if board is locked

7d5eb95

Remove margins from elements and add padding to noteinput

0ea5b5a

Schwehn42 added Changes Requested Blocked This pull request or issue is currently blocked by another issue labels Apr 23, 2024

brandstetterm removed the Changes Requested label Apr 29, 2024

improvement: locked board notification (#4104)

3d2027a

brandstetterm removed the Blocked This pull request or issue is currently blocked by another issue label May 6, 2024

Schwehn42 added 3 commits May 6, 2024 13:07

fix hard coded size and color

80770b4

Merge branch 'refs/heads/main' into mb/lock-board

3f47b6b

# Conflicts: # src/components/MenuBars/MenuBars.tsx

make linter happy

da6ee93

Merge branch 'main' into mb/lock-board

dbffdf2

Schwehn42 added 4 commits May 13, 2024 16:09

Revert "Change logic to hide reactions menu if board is locked"

024b1db

This reverts commit db6d354.

no longer disable board reactions menu

e1abc02

# partial revert from b3a6381

Revert "Hide board reactions menu if board is locked for non-moderators"

ec93947

This reverts commit 48f2461.

remove unused store selector

0dbd526

Schwehn42 mentioned this pull request May 13, 2024

refactor: allowEditing -> isLocked #4145

Merged

1 task

revert: reallow locked board reactions (#4144)

c272368

Schwehn42 added 2 commits May 29, 2024 14:33

refactor: allowEditing -> isLocked (#4145)

f45bf17

Merge branch 'main' into mb/lock-board

f91b3c3

Schwehn42 added the Review Needed This pull request is ready for review label May 29, 2024

Schwehn42 self-assigned this May 29, 2024

Schwehn42 mentioned this pull request May 30, 2024

Notify participants on join if a board is locked #4081

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: lock board #3955

feat: lock board #3955

brandstetterm commented Mar 8, 2024 •

edited

octomind-dev bot commented Mar 11, 2024 •

edited

octomind-dev bot commented Mar 11, 2024 •

edited

octomind-dev bot commented Mar 12, 2024 •

edited

octomind-dev bot commented Mar 12, 2024 •

edited

octomind-dev bot commented Mar 12, 2024 •

edited

Schwehn42 commented Apr 27, 2024

brandstetterm commented Apr 30, 2024

octomind-dev bot commented May 6, 2024 •

edited

octomind-dev bot commented May 7, 2024 •

edited

octomind-dev bot commented May 13, 2024 •

edited

octomind-dev bot commented May 14, 2024 •

edited

octomind-dev bot commented May 29, 2024 •

edited

github-actions bot commented May 29, 2024

octomind-dev bot commented May 29, 2024 •

edited

Schwehn42 commented May 29, 2024

feat: lock board #3955

Are you sure you want to change the base?

feat: lock board #3955

Conversation

brandstetterm commented Mar 8, 2024 • edited

Description

Changelog

Future tasks

Visual changes

octomind-dev bot commented Mar 11, 2024 • edited

🐙 Octomind

octomind-dev bot commented Mar 11, 2024 • edited

🐙 Octomind

octomind-dev bot commented Mar 12, 2024 • edited

🐙 Octomind

octomind-dev bot commented Mar 12, 2024 • edited

🐙 Octomind

octomind-dev bot commented Mar 12, 2024 • edited

🐙 Octomind

Schwehn42 commented Apr 27, 2024

brandstetterm commented Apr 30, 2024

octomind-dev bot commented May 6, 2024 • edited

🐙 Octomind

octomind-dev bot commented May 7, 2024 • edited

🐙 Octomind

octomind-dev bot commented May 13, 2024 • edited

🐙 Octomind

octomind-dev bot commented May 14, 2024 • edited

🐙 Octomind

octomind-dev bot commented May 29, 2024 • edited

🐙 Octomind

github-actions bot commented May 29, 2024

octomind-dev bot commented May 29, 2024 • edited

🐙 Octomind

Schwehn42 commented May 29, 2024

brandstetterm commented Mar 8, 2024 •

edited

octomind-dev bot commented Mar 11, 2024 •

edited

octomind-dev bot commented Mar 11, 2024 •

edited

octomind-dev bot commented Mar 12, 2024 •

edited

octomind-dev bot commented Mar 12, 2024 •

edited

octomind-dev bot commented Mar 12, 2024 •

edited

octomind-dev bot commented May 6, 2024 •

edited

octomind-dev bot commented May 7, 2024 •

edited

octomind-dev bot commented May 13, 2024 •

edited

octomind-dev bot commented May 14, 2024 •

edited

octomind-dev bot commented May 29, 2024 •

edited

octomind-dev bot commented May 29, 2024 •

edited