Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README link title #3598

Closed
wants to merge 4 commits into from
Closed

Conversation

tutacat
Copy link
Contributor

@tutacat tutacat commented May 15, 2024

No description provided.

@iBotPeaches
Copy link
Owner

At the moment there is parity between the docs and tool header. This will break the parity - any reason you feel strongly the hyperlinked [here] is not sufficient?

@tutacat
Copy link
Contributor Author

tutacat commented May 15, 2024

Did not realise that specifically, but theredoes not appear to be parity. README.md does not link to https://apktool.com, only docs header does. the "here" links to each other, but titles such as "here", "click here", and "this link" should not be used for links because a) they don't show what the link is for b) using a screen reader will often list the links on their own separately from the text, so the link title should match content and not rely on additional context.

@iBotPeaches
Copy link
Owner

Okay if you can PR the docs repo as well then (on branch docs) with the same change. I can merge both at once.

@tutacat tutacat changed the title Fix link title - "here" does not show what the link is Improve README link title May 31, 2024
@tutacat
Copy link
Contributor Author

tutacat commented May 31, 2024

Moved to #3611

@tutacat tutacat closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants