Implement automatic resource resolution #3574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iBotPeaches
reviewed
Apr 20, 2024
| public void loadResourceIds(ResTable resTable, File outDir) throws SAXException, IOException, AndrolibException { | ||
| this.loadFrameworkResources(resTable); | ||
| Map<String, File> resourceFiles = new HashMap<>(); | ||
| resourceFiles.put(outDir.getName(), new File(outDir, "res/values/public.xml")); |
There was a problem hiding this comment.
Can you explain this part? I'm not following why we'd generate our own res/values/public.xml. Wouldn't that conflict with the natural generation of it? Is that solely done to keep the API happy with baksmali that needs it?
It seems (albeit maybe memory heavy) - we can keep the resources in memory during disassembly and just reference them during this override of loadResourceIds with some dummy null file that actually queries that hashmap
| throw new AndrolibException("Could not parse framework resources", ex); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
minor nit - can we kill newline?
abdelhak-zaaim
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.