Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Glances v4 #117664

Merged
merged 3 commits into from
May 21, 2024
Merged

Add support for Glances v4 #117664

merged 3 commits into from
May 21, 2024

Conversation

wittypluck
Copy link
Contributor

@wittypluck wittypluck commented May 17, 2024

Proposed change

This PR adds support for Glances v4.
Glances v4 is the new default version in dockerhub since may 2024, so people updating their Glances docker instance to "latest" get an error in Home Assistant (unable to connect).

Glances v4 also introduces a change on network sensor naming, which needs to be handled in the underlying python-glances-api library:
home-assistant-ecosystem/python-glances-api#40

Consequently, this PR upgrades the library glances-api from version 0.6.0 to version 0.7.0.
Changelog:

  • Add support for Glances v4 network sensors (Thanks @wittypluck)

https://github.com/home-assistant-ecosystem/python-glances-api/releases/tag/0.7.0

No change in the support of previous versions of Glances.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @engrbm87, mind taking a look at this pull request as it has been labeled with an integration (glances) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of glances can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign glances Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@engrbm87
Copy link
Contributor

I think CI is failing because the test_entry_deprecated_version assumes that only 2 versions are being tested. This needs to be updated as we are now testing 3 versions.

@wittypluck
Copy link
Contributor Author

Good point, should be fixed now.

@engrbm87
Copy link
Contributor

LGTM

@wittypluck wittypluck marked this pull request as ready for review May 21, 2024 09:44
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wittypluck 👍

@edenhaus edenhaus merged commit 0c37a06 into home-assistant:dev May 21, 2024
33 of 34 checks passed
@wittypluck
Copy link
Contributor Author

Thank you!

@joostlek joostlek added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label May 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed integration: glances noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glances V4 Support
4 participants