-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Glances v4 #117664
Add support for Glances v4 #117664
Conversation
Hey there @engrbm87, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I think CI is failing because the |
Good point, should be fixed now. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wittypluck 👍
Thank you! |
Proposed change
This PR adds support for Glances v4.
Glances v4 is the new default version in dockerhub since may 2024, so people updating their Glances docker instance to "latest" get an error in Home Assistant (unable to connect).
Glances v4 also introduces a change on network sensor naming, which needs to be handled in the underlying python-glances-api library:
home-assistant-ecosystem/python-glances-api#40
Consequently, this PR upgrades the library glances-api from version 0.6.0 to version 0.7.0.
Changelog:
https://github.com/home-assistant-ecosystem/python-glances-api/releases/tag/0.7.0
No change in the support of previous versions of Glances.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: