Synchronize Squeezebox Favourites to media player sources

[peteS-UK]

Breaking change

Proposed change

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @rajlaud, mind taking a look at this pull request as it has been labeled with an integration (squeezebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of squeezebox can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign squeezebox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[balloob]

Favorites should be exposed as media sources and not as sources. Media sources are fetched on demand, so the sync service should be removed.

[peteS-UK]

Thanks @balloob . That'll take changes to the python library as the browse methods don't support favorites at the moment and these libs don't seem to have been touched in quite a few years. @rajlaud, are you open to a PR on the python library if I can figure out the changes to add favorites as a category? PS, I quite liked the favourites being on the main UI of the cards as I'd seen on a couple of other (custom) components, but understand they should really be in the media browse.

[rajlaud]

Hi @peteS-UK, yes, PRs are welcome to the python library.

[peteS-UK]

OK @rajlaud I'll take a look. Favorites work pretty differently to other categories I think, so from a quick glance there's going to be quite a bit of "if category=="favorites" .... else ..... Anyhow, I'll take a look.

[balloob]

You can "fake" a favorites folder in the media browsing inside Home Assistant and just list the same content as you do here. That's also how we do it for some other integrations 👍

[peteS-UK]

Ah c'mon @balloob , you can't tease us like that. Any pointers at which others might do it this way - seems much more sensible than burying a whole separate path in the browse.