Use generator expression in poolsense

[joostlek]

Proposed change

Use generator expression in poolsense

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @haemishkyd, mind taking a look at this pull request as it has been labeled with an integration (poolsense) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of poolsense can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign poolsense Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[Kane610]

Looks good

[jpbede]

This wont work, CI is also complaining. You need to move the PoolSenseConfigEntry here and import it in __init__.py to avoid circular imports like e.g. Shelly

[joostlek]

Hmm, this should work, more integrations have this approach:

core/homeassistant/components/trafikverket_weatherstation/coordinator.py

Lines 24 to 34 in 6cb703a

	if TYPE_CHECKING:
	from . import TVWeatherConfigEntry
	_LOGGER = logging.getLogger(__name__)
	TIME_BETWEEN_UPDATES = timedelta(minutes=10)
	class TVDataUpdateCoordinator(DataUpdateCoordinator[WeatherStationInfo]):
	"""A Sensibo Data Update Coordinator."""
	config_entry: TVWeatherConfigEntry

[Kane610]

It is probably because from __future__ import annotations is not included so you either need to import that or do config_entry: "TVWeatherConfigEntry"

[joostlek]

Oh that first thing is probably it

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[frenck]

Thanks, @joostlek 👍

../Frenck

Comment addressed