The CurlMultiHandle causes a busy immediately when the first byte is received #3218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent loop and avoid busy wait if possible.
|
I'm not sure what I can do with the PHPStan tests. They seem to be unrelated to my patch. |
|
It's probably because you ran composer and phpstan with a different version of PHP. |
|
I made the commit to the 7.8 branch. Should I also make it for the 7.9 and 8.0? |
No. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've provided a patch to the CurlMultiHandler which leverages the event loop. This allows TaskQueue implementations to properly sleep between each invocation of the \curl_multi_exec, and added a curl_multi_select() statement inside the busy wait loop that is meant to "wrap up" things.