-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Deactivate/Reactivate role flow #2537
Open
mknowlton89
wants to merge
53
commits into
main
Choose a base branch
from
mk/deactive-role-flow
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en adding/updating a user.
…code, and fixes a few bugs.
… and checks for custom role feature before building the list of roles in the role selector.
… set as default role and downgrades away from enterprise.
…passing the orgs custom roles to the front end context.
… styling of role selector to handle all reserved roles being deactivated.
mknowlton89
changed the title
[WIP] Mk/deactive role flow
Introduce Deactivate/Reactivate role flow
May 17, 2024
Your preview environment pr-2537-bttf has been deployed. Preview environment endpoints are available at: |
jdorn
reviewed
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
This PR introduces the concept of
deactivating
roles. This feature will only be available toEnterprise
organizations. This is being introduced now that we havecustom-roles
. With custom roles, organizations might want to exclusively use the custom-roles they have defined. Or there may be a single role that doesn't work well within their organization.Deactivating roles allows these orgs to hide them from the role selection UI so someone with
manageTeam
permissions is not able to add it to any new or existing users. If an org does need to, for some reason, undo it, they can reactivate the role.When a role is deactivated, it doesn't change the in-app experience or permissions for any users who have that role applied to their user. It simply provides filtering on the front end.
Testing
/team#roles
/team#roles
Edge Cases:
Screenshots