Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth: Custom oauth provider denied login error message #88030

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Auth: Custom oauth provider denied login error message #88030

wants to merge 5 commits into from
+9 −1

Conversation

EvertonSA
Copy link

@EvertonSA EvertonSA commented May 18, 2024 •
edited

What is this feature?

This PR will allow Grafana server administrators to configure the message showed back to the user when Oauth provider denies the login. For high skilled people, the current behavior is enough to understand what to do, but for my hundreds of business people, they open an IT ticket instead of self requesting access on SailPoint.

Why do we need this feature?

This will enhance Grafana user experience on errors not caused by Grafana.

Who is this feature for?

Server Administrators

Which issue(s) does this PR fix?:

Fixes #88031

Special notes for your reviewer:

I'm very new at golang, please take this into account.

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@EvertonSA EvertonSA requested review from torkelo and a team as code owners May 18, 2024 07:47
@CLAassistant
Copy link

CLAassistant commented May 18, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@grafana-pr-automation grafana-pr-automation bot added area/backend pr/external This PR is from external contributor labels May 18, 2024
@EvertonSA EvertonSA changed the title Feature/custom oauth error message OAuth: custom oauth error message May 18, 2024
@EvertonSA EvertonSA marked this pull request as draft May 18, 2024 07:52
@EvertonSA EvertonSA changed the title OAuth: custom oauth error message OAuth: custom oauth provider denied login error message May 18, 2024
@EvertonSA EvertonSA changed the title OAuth: custom oauth provider denied login error message Auth: custom oauth provider denied login error message May 18, 2024
@EvertonSA EvertonSA changed the title Auth: custom oauth provider denied login error message Auth: Custom oauth provider denied login error message May 18, 2024
@EvertonSA EvertonSA marked this pull request as ready for review May 18, 2024 08:03
@EvertonSA EvertonSA marked this pull request as draft May 18, 2024 08:03
@EvertonSA EvertonSA marked this pull request as ready for review May 31, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkelo torkelo Awaiting requested review from torkelo torkelo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/backend pr/external This PR is from external contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OAUTH provider denied login custom message
2 participants
@EvertonSA @CLAassistant