-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scopes: UI Improvements #88026
Merged
Merged
Scopes: UI Improvements #88026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfmatei
requested review from
lukasztyrala,
bergquist,
kylebrandt,
dprokop,
ashharrison90 and
Ijin08
May 17, 2024 18:18
bfmatei
added
area/dashboard
no-changelog
Skip including change in changelog/release notes
area/scopes
scopes feature
no-backport
Skip backport of PR
labels
May 17, 2024
dprokop
reviewed
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I've left some nits to consider. I suggest implementing some tests before landing this on main :)
public/app/features/dashboard-scene/scene/Scopes/ScopesFiltersBaseSelectorScene.tsx
Outdated
Show resolved
Hide resolved
public/app/features/dashboard-scene/scene/Scopes/ScopesFiltersBasicSelectorScene.tsx
Outdated
Show resolved
Hide resolved
public/app/features/dashboard-scene/scene/Scopes/ScopesFiltersScene.tsx
Outdated
Show resolved
Hide resolved
bfmatei
force-pushed
the
bogdan/scopes-ui-enhancements
branch
2 times, most recently
from
June 4, 2024 07:57
8fe4922
to
9e32096
Compare
bfmatei
requested review from
eledobleefe and
sunker
and removed request for
a team
June 4, 2024 07:57
bfmatei
force-pushed
the
bogdan/scopes-ui-enhancements
branch
3 times, most recently
from
June 5, 2024 16:07
5b6d94f
to
3cd27e9
Compare
3 tasks
bfmatei
force-pushed
the
bogdan/scopes-ui-enhancements
branch
from
June 6, 2024 08:05
3a524b3
to
8507044
Compare
dprokop
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/dashboard
area/frontend
area/scopes
scopes feature
levitate breaking change
A label indicating a breaking change and assigned by Levitate.
no-backport
Skip backport of PR
no-changelog
Skip including change in changelog/release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Implement the new UI for Scopes.
Why do we need this feature?
Have a proper UI for Scopes
Who is this feature for?
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Demo:
720p.mov
Please check that: