Add latency metrics to mode2 #88011
Merged
Add latency metrics to mode2 #88011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonorfmartins
added
the
no-changelog
DanCech
reviewed
May 20, 2024
|
I would add the same observations about |
leonorfmartins
force-pushed
the
dualwriter/mode2_metric
branch
2 times, most recently
from
50b2875
to
5bd7a84
Compare
DanCech
reviewed
May 22, 2024
DanCech
approved these changes
May 22, 2024
DanCech
reviewed
May 22, 2024
DanCech
reviewed
May 22, 2024
leonorfmartins
force-pushed
the
dualwriter/mode2_metric
branch
from
72585af
to
0cb0a77
Compare
miguelmolina95
pushed a commit
to miguelmolina95/grafana
that referenced
this pull request
Jun 3, 2024
* Also call storage on mode1. Add metrics * Update comment * Don't use compare function for now * Remove very important space * Improve code readability on modes 1 and 2 * Fix tests * Return error from legacy write * Renume useless defer * Start adding logging for mode2 * Retrurn errors is storage read fails * Finish adding latency metrics to mode2 * Emit kind to metrics instead * Fix var name * Return if legacy delete list fails * Unify latency calls * Fix get function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Add latency metrics in mode2: in this mode, an error is returned if either of the stores fail.
To be merged after #87739
Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Relates to https://github.com/grafana/search-and-storage-team/issues/29
Special notes for your reviewer:
Please check that: