-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Support custom API URL for PagerDuty integration #88007
Alerting: Support custom API URL for PagerDuty integration #88007
Conversation
gaurav1999
commented
May 16, 2024
- Fixes: Allow user to choose between Pagerduty global and Pagerduty EU endpoint #82741
- Attached with Remove hardocded pagerduty APIURL alerting#174
dd668cf
to
61bf103
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments.
Once the PR in alerting is merged, we need to update the reference to the new version of module.
pkg/services/ngalert/notifier/channels_config/available_channels.go
Outdated
Show resolved
Hide resolved
pkg/services/ngalert/notifier/channels_config/available_channels.go
Outdated
Show resolved
Hide resolved
pkg/services/ngalert/notifier/channels_config/available_channels.go
Outdated
Show resolved
Hide resolved
61bf103
to
a5988d9
Compare
Please run
in the root of this repository. It will import a version of alerting module that contains your changes.
|
a5988d9
to
f53d282
Compare
f53d282
to
a289e7c
Compare
@yuri-tceretian Done from my side, thanks a ton!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oh, CI fails because we forgot to change models for export:
|
- Fixes: grafana/grafana#82741 - Linked PR: grafana/grafana#88007
@yuri-tceretian Sure thing, done -> grafana/terraform-provider-grafana#1576 |
- Fixes: grafana/grafana#82741 - Linked PR: grafana/grafana#88007
@gaurav1999 it looks like you have committed from two accounts. Can you please make sure that you signed CLA with both accounts? |
Have reworked this, should be okay now, I have rebased it to my original author. |
It is still blocked. It looks like you have to sign it with both accounts anyway. |
- Fixes: grafana#82741 - Attached with grafana/alerting#174
8e4fdcf
to
f29ee09
Compare
Nevermind, I squashed your commits into one. Should work now |
* Remove hardocded pagerduty APIURL - Fixes: grafana/grafana#82741 - Linked PR: grafana/grafana#88007 * CI Fixes for docs generation added * go generate * Add pack unpack for pagerduty url * Add test --------- Co-authored-by: Julien Duchesne <julien.duchesne@grafana.com>
@yuri-tceretian Thanks a ton! , loved the experience |