-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon: Remove hardcoded color from ai
icon
#87996
Conversation
public/img/icons/unicons/ai.svg
Outdated
</linearGradient> | ||
</defs> | ||
<svg viewBox="0 0 48 48" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
<path d="M37.3333 24C27.0252 24 18.6675 34.7456 18.6675 48C18.6675 34.7456 10.3098 24 0 24C10.3098 24 18.6675 13.256 18.6675 0C18.6675 13.256 27.0252 24 37.3333 24Z" fill="currentColor" fill-opacity="0.65"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the shapes still be partly transparent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question - this is the icon i was given, so i guess not? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to unify with the rest of our icons and have it solid - no transparencies
@Clarity-89 do i also have to update this icon in the |
You can replace the file in the package's svg folder with the updated svg and it'd be enough. |
What is this feature?
ai
icon and leaves it up to the consumer to implementGenAIButton
these are all used within primary buttons anyway, so they get the color reapplied for free ✅ExplanationButton
andExplanation
in the ml app. this will change to white:Why do we need this feature?
Who is this feature for?
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: