Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Clean up some @grafana/ui SCSS #87986

Merged
merged 4 commits into from
May 20, 2024
Merged

Chore: Clean up some @grafana/ui SCSS #87986

merged 4 commits into from
May 20, 2024

Conversation

ashharrison90
Copy link
Contributor

@ashharrison90 ashharrison90 commented May 16, 2024

What is this feature?

  • moves Drawer and Slider styles to be imported in the component instead of in separate SCSS files
    • this way webpack/rollup just handles everything
  • moves Cascader styles into it's own styles.ts file which is then imported and applied in both Cascader and ButtonCascader
    • here i replaced some old SCSS variables with new theme variables. should be nothing controversial, everything that was picked looks roughly the same and is semantically correct so 馃コ

Why do we need this feature?

  • clean up old SCSS 馃Ч

Who is this feature for?

  • grafana devs

Which issue(s) does this PR fix?:

For #64129

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ashharrison90 ashharrison90 added type/chore no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels May 16, 2024
@ashharrison90 ashharrison90 added this to the 11.1.x milestone May 16, 2024
@ashharrison90 ashharrison90 self-assigned this May 16, 2024
@ashharrison90 ashharrison90 requested a review from a team as a code owner May 16, 2024 14:37
@ashharrison90 ashharrison90 requested review from tskarhed and L-M-K-B and removed request for a team May 16, 2024 14:37
@grafana-pr-automation
Copy link

grafana-pr-automation bot commented May 16, 2024

鈿狅笍 聽聽Possible breaking changes (md version)聽聽 鈿狅笍

grafana-ui

Removals

Cascader.flattenOptions
/home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts
flattenOptions: (options: CascaderOption[], optionPath?: CascaderOption[]) => SelectableValue[];

Cascader.getSearchableOptions
/home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts
getSearchableOptions: micro_memoize.Memoized<(options: CascaderOption[]) => SelectableValue[]>;

Cascader.setInitialValue
/home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts
setInitialValue(searchableOptions: Array>, initValue?: string): {
        rcValue: string[];
        activeLabel: any;
    };

Cascader.onChange
/home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts
onChange: (value: string[], selectedOptions: CascaderOption[]) => void;

Cascader.onSelect
/home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts
onSelect: (obj: SelectableValue) => void;

Cascader.onCreateOption
/home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts
onCreateOption: (value: string) => void;

Cascader.onBlur
/home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts
onBlur: () => void;

Cascader.onBlurCascade
/home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts
onBlurCascade: () => void;

Cascader.onInputKeyDown
/home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts
onInputKeyDown: (e: React__default.KeyboardEvent) => void;

Cascader.onSelectInputChange
/home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts
onSelectInputChange: (value: string) => void;

Cascader.render
/home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts
render(): React__default.JSX.Element;

Cascader.defaultProps
/home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts
static defaultProps: {
        changeOnSelect: boolean;
    };


Read our guideline
Console output

@grafana-pr-automation grafana-pr-automation bot added the levitate breaking change A label indicating a breaking change and assigned by Levitate. label May 16, 2024
@grafana-pr-automation grafana-pr-automation bot requested review from a team and oshirohugo and removed request for a team May 16, 2024 14:42
@grafana-pr-automation grafana-pr-automation bot requested a review from a team May 16, 2024 15:25
@ashharrison90 ashharrison90 merged commit 3800b97 into main May 20, 2024
17 of 18 checks passed
@ashharrison90 ashharrison90 deleted the ash/scss-clean-up branch May 20, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend levitate breaking change A label indicating a breaking change and assigned by Levitate. no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/chore
Projects
Status: 馃殌 Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants