-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Clean up some @grafana/ui SCSS #87986
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashharrison90
added
type/chore
no-backport
Skip backport of PR
no-changelog
Skip including change in changelog/release notes
labels
May 16, 2024
ashharrison90
requested review from
tskarhed and
L-M-K-B
and removed request for
a team
May 16, 2024 14:37
grafana-uiRemovalsCascader.flattenOptions/home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts flattenOptions: (options: CascaderOption[], optionPath?: CascaderOption[]) => SelectableValue[]; Cascader.getSearchableOptions /home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts getSearchableOptions: micro_memoize.Memoized<(options: CascaderOption[]) => SelectableValue[]>; Cascader.setInitialValue /home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts setInitialValue(searchableOptions: Array>, initValue?: string): {
rcValue: string[];
activeLabel: any;
}; Cascader.onChange /home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts onChange: (value: string[], selectedOptions: CascaderOption[]) => void; Cascader.onSelect /home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts onSelect: (obj: SelectableValue) => void; Cascader.onCreateOption /home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts onCreateOption: (value: string) => void; Cascader.onBlur /home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts onBlur: () => void; Cascader.onBlurCascade /home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts onBlurCascade: () => void; Cascader.onInputKeyDown /home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts onInputKeyDown: (e: React__default.KeyboardEvent) => void; Cascader.onSelectInputChange /home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts onSelectInputChange: (value: string) => void; Cascader.render /home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts render(): React__default.JSX.Element; Cascader.defaultProps /home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts static defaultProps: {
changeOnSelect: boolean;
}; |
grafana-pr-automation
bot
added
the
levitate breaking change
A label indicating a breaking change and assigned by Levitate.
label
May 16, 2024
grafana-pr-automation
bot
requested review from
a team and
oshirohugo
and removed request for
a team
May 16, 2024 14:42
joshhunt
approved these changes
May 20, 2024
Clarity-89
approved these changes
May 20, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/frontend
levitate breaking change
A label indicating a breaking change and assigned by Levitate.
no-backport
Skip backport of PR
no-changelog
Skip including change in changelog/release notes
type/chore
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Drawer
andSlider
styles to be imported in the component instead of in separate SCSS filesCascader
styles into it's ownstyles.ts
file which is then imported and applied in bothCascader
andButtonCascader
Why do we need this feature?
Who is this feature for?
Which issue(s) does this PR fix?:
For #64129
Special notes for your reviewer:
Please check that: