Generate nonsemantic shader debug information #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, we are also interested in this feature. Can someone look at this and merge it? |
dneto0
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
The code is good.
The policy question is that when using -g the downstream tools and driver have to undertand non-semantic extended instruction sets. So in theory it's a backward incompatibility. But this is about debug info and it's being used in a development environment so it has to be deliberately turned on, and the remedy is easy: turn it back off.
So I think this is the right thing to do, even with the theoretical incompatibility.
dneto0
force-pushed
the
non-semantic-shader-debug
branch
from
3e04b40
to
8768d60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept fix for #1391.
Possibly
emitNonSemanticShaderDebugInfoandemitNonSemanticShaderDebugSourceshould be controlled using dedicated command line arguments instead of just-g.This worked for me and allowed me to use RenderDoc source debugging.