This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Add a getter to get the camera orientation relative to the devices native orientation #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sibelius
approved these changes
Jan 11, 2019
|
I realised that just after I made this. I've opened a PR over there including both parts react-native-camera/react-native-camera#2050 |
Dimoshka
approved these changes
Apr 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for when you are using the image data from the
onFramePreviewcallback and need to correct the image rotation before sending it through to something like the Mobile Vision SDK.The lack of this was causing libraries to make assumptions about the camera orientation which causes bugs like this: react-native-camera/react-native-camera#1714