unity stand alone build support + unity editor mesh duplicate #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
converted all editor scripts with #if UNITY_EDITOR #endif since they all are namespace which interfaces during runtime in build phase
with [Executeiniditmode] during dublication protedted void Update is being called on the new clones gameobject, which causing to delete the mesh on original gameobject. But after play mode mesh comes back permanent fix is : call destroy DisposeCurrentMesh() only in application is in play mode
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Isn't addition 1 already addressed by 0180d83? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since mujoco namespace holding editor modules which cases to error during stanablone build
MyelinsheathXD@72618db
fixed by calling DestroyImmediate() only when Aplication is in Play mode
MyelinsheathXD@100ad5c
the branch fork link https://github.com/MyelinsheathXD/mujocoGameTools/tree/v2.1.5fromComUnity