Don't define NO_EDITOR_SPLASH in export templates
#91866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 12, 2024
programneer
force-pushed
the
dont-splash-my-editor
branch
from
caacd1c
to
6defe23
Compare
programneer
force-pushed
the
dont-splash-my-editor
branch
from
6defe23
to
efaba30
Compare
akien-mga
approved these changes
May 12, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is good idea to compile export templates with
NO_EDITOR_SPLASHon it since it goes unused anyway.As an bonus, don't generate editor splash header in non-editor builds as well.