Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "Add a new scene" button when Scene Tabs settings change #91859

Merged
merged 1 commit into from May 13, 2024

Conversation

aaronp64
Copy link
Contributor

Updating "Display Close Button" setting (interface/scene_tabs/display_close_button) in Editor Settings changes the size of scene tabs, but the add button at the end of the tabs was not being moved until the next update, causing gaps/overlaps between the controls. Adding call to _scene_tabs_resized() after getting the new settings to update the add button position.

Fixes #91850

Updating "Display Close Button" setting (interface/scene_tabs/display_close_button) in Editor Settings changes the size of scene tabs, but the add button at the end of the tabs was not being moved until the next update, causing gaps/overlaps between the controls.  Adding call to _scene_tabs_resized() after getting the new settings to update the add button position.

Fixes godotengine#91850
@aaronp64 aaronp64 requested review from a team as code owners May 12, 2024 00:17
@KoBeWi KoBeWi added this to the 4.3 milestone May 12, 2024
Copy link
Contributor

@ryevdokimov ryevdokimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024-05-11.20-50-35.mp4

@akien-mga akien-mga merged commit 9cfbd6d into godotengine:master May 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifying Display Close Button in Editor Settings Scene Tabs causes UI issues
5 participants