Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility renderer load of compressed layered GL_TEXTURE_2D_ARRAY #91853

Merged
merged 1 commit into from May 18, 2024
Merged

Fix compatibility renderer load of compressed layered GL_TEXTURE_2D_ARRAY #91853

merged 1 commit into from May 18, 2024

Conversation

semensanyok
Copy link
Contributor

@semensanyok semensanyok commented May 11, 2024 •
edited

fixes #91365

@semensanyok semensanyok requested a review from a team as a code owner May 11, 2024 23:15
@semensanyok semensanyok changed the title fix compatibility gles3 driver load of compressed layered GL_TEXTURE_2D_ARRAY # fixes https://github.com/godotengine/godot/issues/91365fix compatibility gles3 driver load of compressed layered GL_TEXTURE_2D_ARRAY May 11, 2024
@semensanyok semensanyok changed the title # fixes https://github.com/godotengine/godot/issues/91365fix compatibility gles3 driver load of compressed layered GL_TEXTURE_2D_ARRAY fix compatibility gles3 driver load of compressed layered GL_TEXTURE_2D_ARRAY May 11, 2024
@semensanyok semensanyok mentioned this pull request May 11, 2024
Closed
@fire fire changed the title fix compatibility gles3 driver load of compressed layered GL_TEXTURE_2D_ARRAY Fix compatibility renderer load of compressed layered GL_TEXTURE_2D_ARRAY May 12, 2024
@semensanyok semensanyok force-pushed the fix-compatibility-gles3-load-compressed-layered-tex-2dArray branch from 0a4df9b to 0b4ec45 Compare May 12, 2024 09:07
@Chaosus Chaosus added this to the 4.3 milestone May 12, 2024
@akien-mga akien-mga changed the title Fix compatibility renderer load of compressed layered GL_TEXTURE_2D_ARRAY Fix compatibility renderer load of compressed layered GL_TEXTURE_2D_ARRAY May 13, 2024
@clayjohn
Copy link
Member

I left one suggestion. Other than that everything else looks good and I can confirm that this PR works with the MRP!

@semensanyok semensanyok force-pushed the fix-compatibility-gles3-load-compressed-layered-tex-2dArray branch from 0b4ec45 to 07c15ef Compare May 17, 2024 20:00
clayjohn
clayjohn approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for your quick response

@akien-mga akien-mga merged commit 7cd9f61 into godotengine:master May 18, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:rendering
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

VRAM Compressed Texture2DArray formats do not work in Compatibility renderer
4 participants
@semensanyok @clayjohn @akien-mga @Chaosus