Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Fix splash screen background color in HTML shell #91852

Merged
merged 1 commit into from May 13, 2024

Conversation

patwork
Copy link
Contributor

@patwork patwork commented May 11, 2024

Info

I would like to propose a small amendment to the new splash screen related to the background color. My first version used #38363A which came from the div #status-progress of the previous splash screen, but to be consistent with other exporters, the correct background color should be the same as the default application/boot_splash/bg_color from Project Settings, which is #242424.

main/main_builders.py

# Use a neutral gray color to better fit various kinds of projects.
g.write("static const Color boot_splash_bg_color = Color(0.14, 0.14, 0.14);\n")

Difference

Before:

thumb-p1

After:

thumb-p2

Notes

In the future, it may be possible to pass information to the HTML shell about user settings such as application/boot_splash/bg_color or application/boot_splash/show_image. For now, we can add information in the documentation that it is easy to modify the background color by typing CSS in the Head Include field:

<style>
#status { background: radial-gradient(circle, rgba(15,15,121,1) 0%, rgba(25,224,56,1) 100%); }
</style>

thumb-p3

thumb-p4

Similarly, you can hide the splash image by typing:

<style>
#status-splash { display: none; }
</style>

@patwork patwork requested a review from a team as a code owner May 11, 2024 23:10
@AThousandShips AThousandShips added this to the 4.3 milestone May 13, 2024
@akien-mga akien-mga requested a review from a team May 13, 2024 14:50
@akien-mga akien-mga merged commit 13a6df2 into godotengine:master May 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants