Disable viewports inputs when dragging and dropping into the viewport #91845
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryevdokimov
force-pushed
the
disable-freelook-when-drag-and-drop
branch
from
29cf705
to
ec070f2
Compare
|
Edit: Yeah, I think that is probably the way to go, but correct me if I'm wrong. |
ryevdokimov
force-pushed
the
disable-freelook-when-drag-and-drop
branch
2 times, most recently
from
a749522
to
8342eb4
Compare
ryevdokimov
changed the title
ryevdokimov
force-pushed
the
disable-freelook-when-drag-and-drop
branch
from
8342eb4
to
824d21b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #90112 and this comment #90112 (comment)
Having viewport inputs enabled while performing a drag and drop leads to issues especially in different navigation modes as mentioned in the linked issue. In theory the existing behavior sounds good, but in practice I believe it leads to more issues than it's worth. Usually, users put the target location in their viewport before dragging to it.