Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Test property from Internationalization #91824

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

programneer
Copy link
Contributor

Since Test property was also used in non-editor builds, i think an better solution would be to rename it to Override.

@programneer programneer requested review from a team as code owners May 11, 2024 07:35
@programneer programneer changed the title Clarity "Test" property from Internationalization Clarity Test property from Internationalization May 11, 2024
@Chaosus Chaosus added this to the 4.x milestone May 11, 2024
@akien-mga
Copy link
Member

That makes sense to me, but this breaks compatibility, so it's tricky.

We should also consider whether the bug here is the documentation being inaccurate, or the fact that something apparently intended to be an editor-only test option, also works in exported builds.

For editor-only testing, we ought to have better ways to expose this kind of feature than forcing users to modify the project settings, like the new "Customize Run Instances" dialog in 4.3:
image
This already allows overriding the locale by passing --lang fr as argument I believe, but it can maybe be made more user-friendly.

To be clear I'm not saying the compat breakage of renaming this setting wouldn't be acceptable. We just need to make sure we consider the problem fully and provide the solution(s) that are needed. I think renaming this only handles part of the issue.

@AThousandShips AThousandShips changed the title Clarity Test property from Internationalization Clarify Test property from Internationalization May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants