Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asset form header alignment on small screens #17110

Merged

Conversation

cconard96
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #16938

@trasher
Copy link
Contributor

trasher commented May 14, 2024

Just tested on my instance, with debug mode enabled and cache removed; this does not seems to be fixed (using Firefox, no idea if that matters).

Also, I have a display issue in manufacturers (probably due to another change).

image

@trasher
Copy link
Contributor

trasher commented May 14, 2024

(using Firefox, no idea if that matters).

Same with chromium.

@cedric-anne
Copy link
Member

Just tested on my instance, with debug mode enabled and cache removed; this does not seems to be fixed (using Firefox, no idea if that matters).

Also, I have a display issue in manufacturers (probably due to another change).

image

This is the only case corresponding to a label returned in CommonDropdown::getAdditionalFields() returns a HTML string. IMHO, label should never contains HTML. We should refactor this part, for instance by moving this small form in the registeredIDChooser case of CommonDevice::displaySpecificTypeField(). @cconard96 Could you fix it in another PR ?

@cconard96
Copy link
Contributor Author

Just tested on my instance, with debug mode enabled and cache removed; this does not seems to be fixed (using Firefox, no idea if that matters).
Also, I have a display issue in manufacturers (probably due to another change).
image

This is the only case corresponding to a label returned in CommonDropdown::getAdditionalFields() returns a HTML string. IMHO, label should never contains HTML. We should refactor this part, for instance by moving this small form in the registeredIDChooser case of CommonDevice::displaySpecificTypeField(). @cconard96 Could you fix it in another PR ?

This was already fixed for devices in #17027. Its just a matter of looking for missed cases and replicating the fix.

@trasher trasher merged commit cd90f1d into glpi-project:10.0/bugfixes May 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants