Detect and block Cron and CLI running as Root user #17066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconard96
force-pushed
the
enhance/root_detect
branch
from
b47d2fd
to
7a4172f
Compare
|
To be discussed in our weekly meeting, see #6444 |
cedric-anne
reviewed
May 6, 2024
cedric-anne
reviewed
May 14, 2024
cedric-anne
force-pushed
the
enhance/root_detect
branch
from
3da3025
to
331f382
Compare
cedric-anne
approved these changes
May 21, 2024
trasher
approved these changes
May 21, 2024
orthagh
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A source of far too many forum posts, issue reports, etc where people end up with broken GLPI file permissions.
The most common case is when an administrator sets up a cron job for the GLPI automatic actions and simply adds the entry to the system's crontab rather than the web server user's crontab (or specifying the web server user in the system crontab entry).
This PR attempts to detect when the cron script and the GLPI CLI are run as root. If the root user is detected, execution will stop before any file ownership can be ruined.
This uses the
posixextension which is included with PHP and enabled by default (except on Windows where it doesn't apply at all).