Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] use image digest for redis image #19483

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Feb 28, 2024

Description

[installer] use image digest for redis image

Related Issue(s)

Fixes ENG-1717

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This comment was marked as off-topic.

@iQQBot
Copy link
Contributor Author

iQQBot commented Mar 1, 2024

@iQQBot
Copy link
Contributor Author

iQQBot commented Mar 1, 2024

image image

verify image is correct and we can start workspace

@gitpod-io gitpod-io deleted a comment from 31031969 Mar 2, 2024
@gitpod-io gitpod-io deleted a comment from 31031969 Mar 2, 2024
@kylos101
Copy link
Contributor

kylos101 commented Mar 4, 2024

/hold

wait for https://github.com/gitpod-io/gitpod-dedicated/blob/af8aa69fa964a201c44fa518a55a07c1b00178ed/ops/images/push-images.sh#L21C1-L26C7

Hi @iQQBot , what is left/preventing removal of the hold for this PR? I ask because #19402 landed on Feb 7. I assume there is some other PR or Linear issue or Slack thread remaining. Can you share?

@iQQBot
Copy link
Contributor Author

iQQBot commented Mar 4, 2024

@kylos101 not all cell upgrade to this version

@kylos101
Copy link
Contributor

kylos101 commented Mar 4, 2024

@kylos101 not all cell upgrade to this version

Gotcha, thank you, @iQQBot !

@gitpod-io gitpod-io deleted a comment from 31031969 Mar 7, 2024
@gitpod-io gitpod-io deleted a comment from 31031969 Mar 7, 2024
@gitpod-io gitpod-io deleted a comment from 31031969 Mar 7, 2024
Copy link

stale bot commented Mar 17, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Mar 17, 2024
@mustard-mh mustard-mh removed the meta: stale This issue/PR is stale and will be closed soon label Mar 18, 2024
@kylos101 kylos101 added the meta: never-stale This issue can never become stale label Mar 19, 2024
Copy link

socket-security bot commented Jun 11, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package Note
Install scripts npm/core-js@3.32.0
  • Install script: postinstall
  • Source: node -e "try{require('./postinstall')}catch(e){}"

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/core-js@3.32.0

@iQQBot
Copy link
Contributor Author

iQQBot commented Jun 11, 2024

Tested again, it can start a workspace, and redis pod is healthy
image

@iQQBot
Copy link
Contributor Author

iQQBot commented Jun 11, 2024

/unhold

@roboquat roboquat merged commit 25397d8 into main Jun 11, 2024
16 of 17 checks passed
@roboquat roboquat deleted the pd/image-digest-redis branch June 11, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: never-stale This issue can never become stale size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants