add Dockerfile #18
Merged
add Dockerfile #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stephenjannin
commented
Apr 25, 2024
stephenjannin
commented
- Include a Dockerfile for easier build (generated by Copilot :-) )
- Slightly updated README.md to mention it
|
Thanks for your contribution @stephenjannin ! It seems the Dockerfile is breaking the Azure Static Web App deployment 🤔 |
|
Could this come from an issue accessing the secrets ? Similar to Azure/static-web-apps#1342 ? |
|
@martedesco : the "skip_deploy_on_missing_secrets" should fix the GHA. The deployment will be triggered only when you merge the PR or force push on master |
|
Thanks for your contribution @stephenjannin ! Looks good to me 🚀 |
martedesco
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.