feat: add legacyCertsSelector to Map component #54854
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform: learn
Sembauke
added
the
status: blocked
moT01
added
status: waiting review
|
Thank you for working on this, @Sembauke! As I mentioned in the staff chat, I (and Oliver) would suggest not showing the ribbon for The same for the |
|
Hey @sidemt, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
legacyCertsSelectorto tell if a legacy cert is claimed on the superblock ribbons.Before:
After:
The python certification isn't marked as a legacy cert yet, but is already being placed in the map as a legacy cert. Nor does it have a ribbon.
The
Legacy responsive web designicon was already showing up as filled (with ribbon) as we use the sameCertificationenum for the new one. Which led to it being already filled.