fix(curriculum): last assertion for review DOM project step 5 #54841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdwilkin4
added
the
new javascript course
github-actions
bot
added
the
scope: curriculum
jdwilkin4
added
the
status: waiting review
JoyShaheb
requested changes
May 16, 2024
...2/review-dom-manipulation-by-building-a-rock-paper-scissors-game/663d5697d80fef0eea026672.md
Outdated
Show resolved
Hide resolved
JoyShaheb
approved these changes
May 18, 2024
Ksound22
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the test passes without changing the display to block as mentioned in this forum post here
https://forum.freecodecamp.org/t/review-dom-manipulation-by-building-a-rock-paper-scissors-game-step-5/690574
The update the last assertion fixes that
Checklist:
mainbranch of freeCodeCamp.Closes #XXXXX