feat(curriculum): add Projectile Trajectory project to SciComPy

[ilenia-magoni]

Checklist:

• I have read and followed the contribution guidelines.
• I have read and followed the how to open a pull request guide.
• My pull request targets the main branch of freeCodeCamp.
• I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

[Dario-DC]

Once the tests are fixed, instructions can be refined a bit for the last steps but it's looking very good!

[zairahira]

Reviewed the project and left a few comments.
Also, I wasn't able to pass the steps 18, 19 and 20.

Some steps(like step-2) are too wordy and would need to be revised.

Once Dario's reviews are resolved, I'll take another thorough look.

[fhsinchy]

I went through the steps. Looks fine to me. I managed to pass all the steps. The text looks great too.

[Dario-DC]

Remember to add intro.

[Dario-DC]

Remember to check the order.

[zairahira]

I have reviewed all the steps, the tests ran fine for all of them.
I have left a couple of comments, after that the project is ready to go from my end.

[ilenia-magoni]

Needs to be fleshed out, see #43289 (comment)

[gikf]

I'm a silly person and I spent about minute contemplating why copied from description:

PROJECTILE = "∙"

Is passing test, but when I write it:

PROJECTILE = '.'

or

PROJECTILE = "."

It doesn't.

Maybe from the start suggest in description copying all of them? Or move them to seed code?

[gikf]

Suggested change

	You should use the `__slots__` variable inside the class to define which attributes the class has: assign to `__slots__` a tuple containing 3 strings, each equal to one of the attribute names.
	You should use the `__slots__` variable inside the class to define which attributes the class has: assign to `__slots__` a tuple containing 3 strings, each equal to one of the attribute names defined in the `__init__`.

[gikf]

Suggested change

	Remember that with name mangling you need to call the method as `_Projectile__calculate_displacement` if you want to test it:
	Remember that with name mangling you need to call the method as `_Projectile__calculate_displacement` if you want to test, or use it from outside of the class:

[gikf]

Suggested change

	\\[ d = \frac{v^2 \cdot \cos(\theta) \cdot \left(\sin(\theta) + \sqrt{\sin^2(\theta) + \frac{2 \cdot g \cdot h}{v^2}}\right)}{g} \\]
	\\[ d = \frac{v^2 \cdot \cos\theta \cdot \left(\sin\theta + \sqrt{\sin^2\theta + \frac{2 \cdot g \cdot h}{v^2}}\right)}{g} \\]

Parenthesis by sin and cos could be dropped to reduce the noise a little.

[gikf]

Another part that might be hard for somebody unfamiliar with the notation is:

[gikf]

If somebody would want to slightly introduce another module - operator, this could be written without lambdas:

Suggested change

	x_max = max(rounded_coords, key=lambda i: i[0])[0]
	y_max = max(rounded_coords, key=lambda j: j[1])[1]
	x_max = max(rounded_coords, key=operator.itemgetter(0))[0]
	y_max = max(rounded_coords, key=operator.itemgetter(1))[1]

[gikf]

Suggested change

	`matrix_list` is a list of lists, each element has an x,y coordinate. Use the list of coordinates in `rounded_coords` to change the elements in `matrix_list` at the coordinates in the list to the symbol in the `PROJECTILE` variable. Remember that a coordinates graph has the 0,0 in the bottom left corner.
	`matrix_list` is a list of lists, each element has an (x, y) coordinate. Use the list of coordinates in `rounded_coords` to change the elements in `matrix_list` at the coordinates in the list to the symbol in the `PROJECTILE` variable. Remember that a coordinates graph has the (0, 0) in the bottom left corner.

[gikf]

This isn't very readable in next steps, which might make it harder to get the correct results.

Maybe another step could be added to change it for couple steps?:

for row in graph.create_trajectory()
    print(row)

[gikf]

Is it just me, or this is not fully looking like it should?

Are the special characters messing up mono-spacing?

[ilenia-magoni]

Yes, they are messing up the mono-spacing, let me see if I find a different character...

[gikf]

If the exact value from function is tested (next hint) I think it's fine to not check how the returned thing is named in function. This likely apply to couple other steps.