Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: convert show cert from superblock tests to Playwright #54836

Merged
merged 6 commits into from
May 24, 2024
Merged

feat: convert show cert from superblock tests to Playwright #54836

merged 6 commits into from
May 24, 2024

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented May 16, 2024 •
edited

Checklist:

Closes #XXXXX

@Sembauke Sembauke requested a review from a team as a code owner May 16, 2024 13:40
@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels May 16, 2024
@Sembauke Sembauke marked this pull request as draft May 16, 2024 13:40
@Sembauke Sembauke marked this pull request as ready for review May 16, 2024 14:10
@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 20, 2024
@Sembauke Sembauke mentioned this pull request May 21, 2024
Open
61 tasks
@huyenltnguyen huyenltnguyen added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels May 22, 2024
@huyenltnguyen huyenltnguyen self-assigned this May 22, 2024
@github-actions github-actions bot removed the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label May 23, 2024
@Sembauke Sembauke added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels May 23, 2024
@huyenltnguyen
Copy link
Member

CI was stuck so I don't know if this is only an issue with my local environment, but tests failed on my end:

Screenshot 2024-05-24 at 13 52 29

I went ahead and changed the tests from actually clicking the link to just checking if the link contains the correct URL, which should make the tests a little faster since they don't have to perform navigation.

@huyenltnguyen huyenltnguyen enabled auto-merge (squash) May 24, 2024 07:20
@huyenltnguyen huyenltnguyen merged commit 8b62361 into freeCodeCamp:main May 24, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huyenltnguyen huyenltnguyen huyenltnguyen approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees

@huyenltnguyen huyenltnguyen

Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sembauke @huyenltnguyen @naomi-lgbt @moT01