Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(curriculum-build): add meta schema and normalize meta #54823

Merged
merged 5 commits into from
May 31, 2024

Conversation

moT01
Copy link
Member

@moT01 moT01 commented May 15, 2024

This adds a schema validator for the meta.json files so there isn't any inconsistencies is less inconsistencies.

It removes four things in the meta.json files:
template values that are an empty string
required values that are an empty array
time values that are an empty string
superOrder values

Quite sure they aren't needed.

Also, formats a few files to use two spaces instead of four.

Checklist:

Closes #XXXXX

@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels May 15, 2024
@moT01 moT01 marked this pull request as ready for review May 16, 2024 02:30
@moT01 moT01 requested a review from a team as a code owner May 16, 2024 02:30
@moT01 moT01 added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label May 16, 2024
@moT01
Copy link
Member Author

moT01 commented May 16, 2024

I'm gonna see if I can add some tests

@moT01 moT01 force-pushed the chore/remove-unused-meta branch from c144310 to 3d6688c Compare May 24, 2024 14:53
@moT01 moT01 changed the title chore: remove unused meta feat(curriculum-build): add meta schema and normalize meta" May 24, 2024
@moT01 moT01 changed the title feat(curriculum-build): add meta schema and normalize meta" feat(curriculum-build): add meta schema and normalize meta May 24, 2024
@moT01 moT01 added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. labels May 24, 2024
@moT01 moT01 force-pushed the chore/remove-unused-meta branch from 3fb70e4 to 1b1c161 Compare May 28, 2024 13:09
curriculum/get-challenges.js Outdated Show resolved Hide resolved
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has validation ❤️. A+ would review again.

@ShaunSHamilton ShaunSHamilton merged commit cd551a1 into freeCodeCamp:main May 31, 2024
21 checks passed
@ojeytonwilliams ojeytonwilliams deleted the chore/remove-unused-meta branch May 31, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants