Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce premature skipping of donation animation #54817

Merged
merged 4 commits into from
May 23, 2024
Merged

fix: reduce premature skipping of donation animation #54817

merged 4 commits into from
May 23, 2024

Conversation

ahmaxed
Copy link
Member

@ahmaxed ahmaxed commented May 15, 2024 •
edited

This pr has two objectives.

  1. Remove the skip button
  2. Remove the ability to skip the animation on page refresh

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

@ahmaxed ahmaxed requested a review from a team as a code owner May 15, 2024 20:13
@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels May 15, 2024
naomi-lgbt
naomi-lgbt reviewed May 15, 2024
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, but advertisement has a lot of negative connotation with it - and technically, we're not advertising as much as we're asking for support.

Tried to go for something that had a more neutral tone.

client/i18n/locales/english/translations.json Outdated Show resolved Hide resolved
@ahmaxed ahmaxed changed the title feat: remove donation animation skip button fix: reduce premature skipping of donation animation May 16, 2024
@ahmaxed ahmaxed added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels May 16, 2024
@huyenltnguyen huyenltnguyen self-assigned this May 22, 2024
@huyenltnguyen huyenltnguyen merged commit 72e10e5 into freeCodeCamp:main May 23, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huyenltnguyen huyenltnguyen huyenltnguyen approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees

@huyenltnguyen huyenltnguyen

Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmaxed @huyenltnguyen @naomi-lgbt