fix(curriculum): prevent hardcoding palidrome checker answers #54816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
scope: curriculum
...thms-and-data-structures-22/build-a-palindrome-checker-project/build-a-palindrome-checker.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ilenia <26656284+ilenia-magoni@users.noreply.github.com>
gikf
reviewed
May 15, 2024
...thms-and-data-structures-22/build-a-palindrome-checker-project/build-a-palindrome-checker.md
Outdated
Show resolved
Hide resolved
|
I think one more test is required, to cover generated non-palindrome. Otherwise there's option to hardcode the specific cases and anything else consider as a palindrome. |
Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
ilenia-magoni
approved these changes
May 16, 2024
zairahira
added
the
new javascript course
moT01
added
the
status: waiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.Ref #54063
This generates one random phrase consisting of both numbers and lowercase letters. It'd be extremely difficult to hard-code a solution for this test. It'd be a lot less work just solving the problem rather than predicting whatever is generated.