Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): give expected default if field missing #54807

Merged

Conversation

ojeytonwilliams
Copy link
Contributor

api-server defines a lot of default values in user.json, so the new api
should respect them.

Checklist:

api-server defines a lot of default values in user.json, so the new api
should respect them.
@ojeytonwilliams ojeytonwilliams requested a review from a team as a code owner May 15, 2024 14:46
@github-actions github-actions bot added the platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. label May 15, 2024
@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 20, 2024
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I hate it

@ojeytonwilliams
Copy link
Contributor Author

Thanks I hate it

Me too. It'll get better once the database contains the right data, but this is ripe for refactoring.

@ahmaxed ahmaxed merged commit e877b92 into freeCodeCamp:main May 22, 2024
22 checks passed
@ojeytonwilliams ojeytonwilliams deleted the fix/get-session-user-output branch May 22, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants