-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FocusManager
platform check to include iOS
#148612
Conversation
@@ -1521,12 +1521,21 @@ class FocusManager with DiagnosticableTreeMixin, ChangeNotifier { | |||
if (kFlutterMemoryAllocationsEnabled) { | |||
ChangeNotifier.maybeDispatchObjectCreation(this); | |||
} | |||
if (kIsWeb || defaultTargetPlatform != TargetPlatform.android) { | |||
final bool shouldListenToAppLifecycle = switch (defaultTargetPlatform) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having the focus system automatically handle app lifecycle state changes is convenient in most cases, but what if a UI component wants to respond to app lifecycle events and user-initiated focus changes differently? If we do this automatically in the focus system, there's no way for a component to distinguish user-initiated focus changes and app-lifecycle focus changes.
For example a text field establishes / tears down an input connection based on whether it currently has focus. Automatically unfocusing on app pause doesn't work well. It makes more sense to me that UI components should have logic to handle app lifecycle changes themselves (at least for text fields that's the case).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting all UI components (not just text fields) to automatically unfocus/refocus based on app lifecycle state matches the behavior of other non-Flutter apps.
But the fact that a widget may want to differentiate between app lifecycle events and user-initiated focus changes is a great point.
In my mind, it makes sense to apply the iOS platform check today, and then sometime soon we should swap out the current app lifecycle listener for a more robust implementation that allows for the TextField
input connection optimization you mentioned.
Both iOS and Android run into issues when the FocusManager starts responding to app lifecycle changes. Fortunately, this feature is primarily meant for desktop platforms, so the problem can be resolved with a platform check. fixes flutter#148475
This reverts commit 8d955cd.
flutter/flutter@73bf206...8d955cd 2024-05-23 nate.w5687@gmail.com Update `FocusManager` platform check to include iOS (flutter/flutter#148612) 2024-05-23 matej.knopp@gmail.com [iOS] fix hot restart with native assets (flutter/flutter#148752) 2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from b8b82454e302 to 964f087f288c (8 revisions) (flutter/flutter#148943) 2024-05-23 104349824+huycozy@users.noreply.github.com Fix DecoratedSliver sample code to reflect the description (flutter/flutter#148621) 2024-05-23 82763757+NobodyForNothing@users.noreply.github.com Test raw autocomplete api examples (flutter/flutter#148234) 2024-05-23 32538273+ValentinVignal@users.noreply.github.com Add test for scaffold.0.dart and scaffold.2.dart (flutter/flutter#148166) 2024-05-23 sokolovskyi.konstantin@gmail.com Add tests for restorable_value.0.dart API example. (flutter/flutter#148676) 2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8b094fbb94d8 to b8b82454e302 (6 revisions) (flutter/flutter#148919) 2024-05-22 31859944+LongCatIsLooong@users.noreply.github.com Allow `RenderObject.getTransformTo` to take an arbitrary RenderObject in the same tree (flutter/flutter#148897) 2024-05-22 kevinjchisholm@google.com 3.22.1 changelog updates (flutter/flutter#148895) 2024-05-22 helinx@google.com Add frame number and widget location map service extension (flutter/flutter#148702) 2024-05-22 31859944+LongCatIsLooong@users.noreply.github.com Remove an assert with false positives (flutter/flutter#148795) 2024-05-22 rmolivares@renzo-olivares.dev Revert "Fix the second TextFormField to trigger onTapOutside" (flutter/flutter#148909) 2024-05-22 katelovett@google.com [wiki migration] Remaining pages under docs/about/ (flutter/flutter#148782) 2024-05-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from b6971cdf14f8 to 8b094fbb94d8 (3 revisions) (flutter/flutter#148883) 2024-05-22 42757204+wyqlxf@users.noreply.github.com Fix the second TextFormField to trigger onTapOutside (flutter/flutter#148206) 2024-05-22 34871572+gmackall@users.noreply.github.com Try removing robolectric from `integration_test` tests (flutter/flutter#148803) 2024-05-22 victoreronmosele@gmail.com Prevent test folder deletion on running `flutter create --empty` on an existing app project (flutter/flutter#147160) 2024-05-22 katelovett@google.com [wiki migration] Tool team pages (flutter/flutter#148779) 2024-05-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from c89defa55801 to b6971cdf14f8 (6 revisions) (flutter/flutter#148819) 2024-05-22 dacoharkes@google.com [native_assets] Add support for link hooks (flutter/flutter#148474) 2024-05-22 engine-flutter-autoroll@skia.org Roll Packages from ba19b24 to 6525441 (12 revisions) (flutter/flutter#148864) 2024-05-22 36861262+QuncCccccc@users.noreply.github.com Update tokens to 4.0.0 (flutter/flutter#148789) 2024-05-22 zanderso@users.noreply.github.com Move Linux web_long_running_tests_2_5 to bringup (flutter/flutter#148854) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FYI: this PR introduced a memory leak |
Both iOS and Android run into issues when the FocusManager starts responding to app lifecycle changes. Fortunately, this feature is primarily meant for desktop platforms, so the problem can be resolved with a platform check. fixes flutter#148475
Both iOS and Android run into issues when the FocusManager starts responding to app lifecycle changes.
Fortunately, this feature is primarily meant for desktop platforms, so the problem can be resolved with a platform check.
fixes #148475