added support for redis connection pools #839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@jnunemaker could you rerun the failed test? |
|
@j-castellanos Thanks for the PR! In #826 (review) I offered a couple suggestions of how I think we should approach connection pool support. I don't really love having different adapters Redis depending on if you're using the client directly or a connection pool. I'd rather see I don't feel strongly between those two approaches, but I would like to make sure we add connection pool support to both Thoughts? |
j-castellanos
force-pushed
the
redis-pool-adapter
branch
from
d0c5845
to
d5d76ba
Compare
|
@bkeepers how is this? |
removing idea fixing specs
j-castellanos
force-pushed
the
redis-pool-adapter
branch
from
d5d76ba
to
a55636d
Compare
j-castellanos
commented
Feb 18, 2024
| def initialize(client_or_pool = nil, key_prefix: nil) | ||
| @pool = nil | ||
| @client = nil | ||
| if client_or_pool.respond_to?(:with) |
There was a problem hiding this comment.
Maybe is_a?(ConnectionPool) might be better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve this issue #609 in a DRY way I simply wrap all the public methods in the existing redis adapter