Added ability to throw a method not found instead of 404 #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n0nag0n
commented
May 17, 2024
| // Process things normally for before, and then in reverse order for after. | ||
| $middlewares = $eventName === Dispatcher::FILTER_BEFORE | ||
| ? $route->middleware | ||
| : array_reverse($route->middleware); | ||
| $params = $route->params; |
There was a problem hiding this comment.
This will look better if you remove the whitespace setting in the CR
luka97zr
reviewed
May 17, 2024
| // Get the previous route and check if the method failed, but the URL was good. | ||
| $lastRouteExecuted = $router->executedRoute; | ||
| if ($lastRouteExecuted !== null && $lastRouteExecuted->matchUrl($request->url) === true && $lastRouteExecuted->matchMethod($request->method) === false) { | ||
| $this->halt(405, 'Method Not Allowed', empty(getenv('PHPUNIT_TEST'))); |
There was a problem hiding this comment.
Sweet, I like this, so helpful for debugging!
luka97zr
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are routing a URL and it finds the URL, but not the method, this allows a 405 Method Not Found error to be thrown instead of the expected 404 Not Found.