Update contribution guidelines #4619
Merged
+40
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
added
the
Status: Awaiting review
roypat
force-pushed
the
update-contribution-guidelines
branch
from
ea07dd3
to
9de3bc4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4619 +/- ##
=======================================
Coverage 82.08% 82.08%
=======================================
Files 255 255
Lines 31256 31256
=======================================
Hits 25658 25658
Misses 5598 5598
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
force-pushed
the
update-contribution-guidelines
branch
from
9de3bc4
to
abc3bde
Compare
xmarcalx
approved these changes
May 20, 2024
PRs can only get merged if it has at least 2 approvals from maintainers, not 1 approval from a maintainer and 1 approval from someone else (which doesn't make sense). Additionally, all review comments need to be addressed. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Sudan has left the team. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Clarifies that we want to avoid unwraping in favor of propagating errors. Closes firecracker-microvm#808 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
ShadowCurse
force-pushed
the
update-contribution-guidelines
branch
from
abc3bde
to
3eddd50
Compare
ShadowCurse
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.unwrap()Reason
#808
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.