-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bindgen.sh and solve TODO #4520
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4520 +/- ##
==========================================
- Coverage 82.14% 80.06% -2.08%
==========================================
Files 255 255
Lines 31278 30029 -1249
==========================================
- Hits 25692 24042 -1650
- Misses 5586 5987 +401
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1f22919
to
ceb3ea6
Compare
`bindgen.sh` was broken for the following reasons: - `--size_t-is-usize` was removed since it became default behavior. - `*_gen` crates were moved under `vmm` crate and patching `iff.rs` no longer works. - `io_uring` crate was moved under `vmm` crate and the bindings path became wrong. Fix `bindgen.sh` and regenerates bindings. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
2f4a45e
to
f2e37bb
Compare
Generates Rust code from `prctl.h` and removes TODO. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re: the layout... should we keep all the gen
stuff together in one crate, or spread over many crates?
@@ -0,0 +1,26 @@ | |||
From 8faa5d38ebe9b6bd27fda01dd8f54d3d91583166 Mon Sep 17 00:00:00 2001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm this is a git format-patch
patch... I'm not sure it is 100% compatible with patch
. Could we use git am
below to apply this patch?
Huh, I didn't realize the bindings are included in the coverage reports. Should we exclude them? The bindgen generated unit tests are not a inside of test modules, so their lines are included in coverage reports, but since they have |
Changes
bindgen.sh
prctl.h
and solve TODOReason
bindgen.sh is broken for the following reasons:
--size_t-is-usize
was removed since it became default behavior.*_gen
crates were moved undervmm
crate and patchingiff.rs
no longer works.Additional Info
ABI is compatbile.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.[ ] Any required documentation changes (code and docs) are included in thisPR.
[ ] API changes follow the Runbook for Firecracker API changes.[ ] User-facing changes are mentioned inCHANGELOG.md
.[ ] NewTODO
s link to an issue.contribution quality standards.
rust-vmm
.