Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added support for displaying all network folders on the sidebar #15388

Merged
merged 4 commits into from May 13, 2024

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open Files.
  2. Wait a moment. You can continue to use the app while loading network folders.
  3. Network folders will be displayed on the sidebar.

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use IAsyncEnumerable in the future while current implementation doesn't allow for now, and it's out of scope of this PR.

@0x5bfa 0x5bfa added needs-testing Pull request requires testing before being merged and removed needs-code review labels May 13, 2024
@hishitetsu
Copy link
Member Author

hishitetsu commented May 13, 2024

This PR displays network computers instead of network location shortcuts. Should both be displayed? Explorer displays only network computers in the sidebar, but Files doesn't have any other locations to display network location shortcuts.

@yaira2 yaira2 added needs-code review and removed needs-testing Pull request requires testing before being merged labels May 13, 2024
@yaira2
Copy link
Member

yaira2 commented May 13, 2024

This PR displays network computers instead of network location shortcuts. Should both be displayed? Explorer displays only network computers in the sidebar, but Files doesn't have any other locations to display network location shortcuts.

Should we try both and adjust based on feedback?

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs-code review labels May 13, 2024
@yaira2
Copy link
Member

yaira2 commented May 13, 2024

Small chance but does this help for #13087?

@yaira2 yaira2 merged commit d16ae0e into files-community:main May 13, 2024
6 checks passed
@hishitetsu
Copy link
Member Author

Small chance but does this help for #13087?

No, that is the problem with loading quick access items, not network locations or computers.

@hishitetsu
Copy link
Member Author

This PR displays network computers instead of network location shortcuts. Should both be displayed? Explorer displays only network computers in the sidebar, but Files doesn't have any other locations to display network location shortcuts.

Should we try both and adjust based on feedback?

Shouldn't I have changed it to show both network locations and network computers?

@yaira2
Copy link
Member

yaira2 commented May 13, 2024

If we only show network computers, where would we show locations? On the home page?

@hishitetsu
Copy link
Member Author

If we only show network computers, where would we show locations? On the home page?

There are no places to display it now, but I think it should be displayed on the home page. Maybe we should create a widget for it.
#5135

@yaira2
Copy link
Member

yaira2 commented May 13, 2024

That sounds fair, in that case we can leave this PR as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Display all network folders on the sidebar
3 participants