New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added support for displaying all network folders on the sidebar #15388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use IAsyncEnumerable in the future while current implementation doesn't allow for now, and it's out of scope of this PR.
This PR displays network computers instead of network location shortcuts. Should both be displayed? Explorer displays only network computers in the sidebar, but Files doesn't have any other locations to display network location shortcuts. |
Should we try both and adjust based on feedback? |
Small chance but does this help for #13087? |
No, that is the problem with loading quick access items, not network locations or computers. |
Shouldn't I have changed it to show both network locations and network computers? |
If we only show network computers, where would we show locations? On the home page? |
There are no places to display it now, but I think it should be displayed on the home page. Maybe we should create a widget for it. |
That sounds fair, in that case we can leave this PR as is. |
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build
. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.