New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Removed Vanara.PInvoke.Mpr & Vanara.PInvoke.DwmApi #15292
base: main
Are you sure you want to change the base?
Conversation
@gave92 I'd like to request to review since I changed codes around the preview handler. The total amount of size of Vanara is about 4.12 MB, while DirectN has 4.85 MB. Do you think DirectN can be replaced with CsWin32? |
{ | ||
return true; | ||
} | ||
else | ||
{ | ||
await DialogDisplayHelper.ShowDialogAsync("NetworkFolderErrorDialogTitle".GetLocalizedResource(), connectionError.ToString().Split(":")[1].Trim()); | ||
await DialogDisplayHelper.ShowDialogAsync("NetworkFolderErrorDialogTitle".GetLocalizedResource(), res.ToString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to remove the ".Split(":")[1].Trim()"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found out in the first place this is not needed.
Files/src/Files.App/Strings/en-US/Resources.resw
Lines 2217 to 2219 in ea18185
<data name="NetworkFolderErrorDialogTitle" xml:space="preserve"> | |
<value>Network folder error</value> | |
</data> |
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build
. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.