Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color for started task item #268

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

fsevenm
Copy link

@fsevenm fsevenm commented Jun 3, 2020

In the current feature, there is no color mark for started task items. We have to check at the end of the line whether there is a started/in-progress tag or not, or we have to click at the timer on the status bar, so our cursor will be located at the front of that started task. Started task and other tasks which have the same color make our eyes pretty hard to find the started one because it does not have enough contrast for our eyes to focus on it quickly.

This pull request aims to fix that problem by adding color to the started tasks. The color can also be configured in Settings. The method used here is the same way as adding color for the done ones or the canceled ones.

@fabiospampinato
Copy link
Owner

Is this coloring the entire task? I'm not sure we would want that as that conflicts with other decorations 🤔 Maybe the background color could be changed or something.

@fsevenm
Copy link
Author

fsevenm commented Sep 12, 2020

Nope, the other decorations will have no effect. Tag @, custom background, timestamp will stay with its own styles. Except the bold style will affect the entire task. Done, Cancelled tasks also with its own style. Here is the proof https://pasteboard.co/JqO134S.gif

@fabiospampinato
Copy link
Owner

Nice, thanks.

I'm not sure if this should be added to the extension, it sounds a bit niche to me. I've opened this issue about it: #292 let's see what people say about it / how many upvotes it will get.

@fsevenm
Copy link
Author

fsevenm commented Sep 13, 2020

The idea first came from my needs. But, I thought, it maybe useful for other people too, so I made it a PR, instead of just forked it and made a customization. But okay, let's see if they really need it or not.

@CaptnCodr
Copy link

Hey @fabiospampinato, can this be merged? I tested it since the last version of @fsevenm's extension.
It works very well. 🙂
What do you think?

albuemil added a commit to albuemil/vscode-todo-plus-plus that referenced this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants