Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add camera pan method #1431

Merged
merged 4 commits into from
May 21, 2024
Merged

add camera pan method #1431

merged 4 commits into from
May 21, 2024

Conversation

snoyer
Copy link
Contributor

@snoyer snoyer commented May 20, 2024

fixes #1430

Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

library/public/camera.h Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (6133d0f) to head (f26ae0a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1431   +/-   ##
=======================================
  Coverage   96.57%   96.58%           
=======================================
  Files         103      103           
  Lines        7679     7701   +22     
=======================================
+ Hits         7416     7438   +22     
  Misses        263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed

library/public/camera.h Outdated Show resolved Hide resolved
@snoyer snoyer requested review from Meakk and mwestphal May 21, 2024 15:59
@mwestphal mwestphal merged commit 6168ad9 into f3d-app:master May 21, 2024
42 checks passed
@snoyer snoyer deleted the camera-pan branch May 22, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Pan method
3 participants