-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt Node@18 as the minimum supported version #5595
base: 5.x
Are you sure you want to change the base?
Conversation
I had been thinking about this last night after our meeting and I was thinking that we should get all the dependencies working as we expect first and then do this specific change last. Maybe I am over thinking it, but I really do think it will be valuable to point specifically to the commits we landed which "broke" each node.js version. If we stop testing and do this early we loose that signal and it might be hard to untangle after the fact. |
AFAIK, there is no rush to merge this PR. It can be the last one before we officially release v5. Let's keep it open for a while and see how do we feel about it in few more commits 👍 |
Yes and no. Keeping old versions in CI prevents usage of any new JS and Node.js features. |
We can remove them in an ad-hoc way. That is sort of why I am not sure this specific PR would be what we even land, but I don't see any reason not to keep it open for now until we are sure. |
If there isnt intent to merge rn then lets move to draft |
So I think maybe the docs have gotten a bit ahead of ourselves here as we say 5.x requires Node 18+ ... IIUC I think we do SUPPORT v18+ but technically we require a lower version. I probably changed this wording because I thought this was decided, my bad. Probably not a huge deal since anyone who's using 5 has sorted this out... but if this isn't going to land soon, then should we say something different to be accurate? |
As discussed in expressjs/discussions#224 and expressjs/discussions#196.
Here is a proposal to set Node@18 as the minimum version supported by Express v5.x
Main Changes
package.json
(4b3b8cc)Changelog