Re-export types from expo-modules-core in expo package #28994
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
expo
package should re-export some common and stable APIs fromexpo-modules-core
that we would like to show in the docs.How
This PR re-exports
EventEmitter
,SharedObject
andNativeModule
classes fromexpo-modules-core
.Additionally, I'm introducing
expo/types
import which exports these three classes but as types instead of values. They have the same names, so exporting them from the main entry point is a bit tricky. Docs data generation also needs these types to be exposed.Test Plan