Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for the Waveshare 2.7 Inch V2 e-Ink display #1189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

UnaKarlsen
Copy link

@UnaKarlsen UnaKarlsen commented Nov 25, 2023

Description

I started with the existing Waveshare 2.7 Inch driver, and swapped out the necessary library from Waveshare for version 2 one, and modify the uses of the clear() function to not specify a background colour as V2 does not take arguments in it's implementation of clear().

This was all that was needed in order to make the driver work.

Motivation and Context

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

I have successfully run this new code on my 2.7 inch v2 hardware for several weeks now with no issues.
Tests were run with a Raspberry Pi Zero W.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

Signed-off-by: Una Karlsen <una@unakarlsen.com>
Signed-off-by: Una Karlsen <una@unakarlsen.com>
Copy link

@oreoorin6 oreoorin6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@tcsabina
Copy link

How to make this work?
Do we need to create an image after this is merged? Can I try this without it?
I can change/add the files of this PR to my running OS, but I am not sure what do I need to do after it?
Simply adding the 'waveshare27inch_V2' as display in the 'config.taml' file ends up with this error:

pi@Edison:~ $ pwnagotchi
unsupported display type waveshare27inch_V2

@tcsabina
Copy link

This made it work:

  1. Shut down the pwnagotchi service (systemctl stop pwnagotchi)
  2. Replace the source located in /usr/local/lib/python3.7/site-packages/pwnagotchi with the changes from this PR
  3. Restart the pwnagotchi service and verify screen is correctly initialised and pwnagotchi displayed on it

@Jimboow
Copy link

Jimboow commented May 26, 2024

I dont find the right path i just got the python 3.7/dist-packages and no site-packages path didnt bring it to work

@tcsabina
Copy link

I dont find the right path i just got the python 3.7/dist-packages and no site-packages path didnt bring it to work

Maybe you are on the wrong folder?
Do a find / -type d -name "dist-packages" to list all folders called dist-packages...

@Jimboow
Copy link

Jimboow commented May 28, 2024

I used the find command and found usr/local/lib/python2.7/site-packages
And usr/local/lib/python3.7/dist-packages
In the 3.7 how explained i didnt have a site-packages path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants