fix: traceCall having baseFee 0 despite gas price being set. #29787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes baseFee being zero despite gas prices being set.
There are situations in tracing where we would like the baseFee not to be zero. This is to get traces that are as accurate to transaction execution as possible. In the current implementation of
NewEVMinsidetraceTx, theGasPriceis set to a dummy price of 0 despite the transaction including a gas price. This results in the block context base fee always being set to zero.To solve this, we pass in the gas price provided by the transaction.
The bug was introduced in 064f37d during the rework of tracing.