Fix: A symptom of characters being copied when there are multiple TextEdits. #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Apr 21, 2024
| @@ -44,6 +44,10 @@ pub struct TextEditState { | |||
| #[cfg_attr(feature = "serde", serde(skip))] | |||
| pub(crate) has_ime: bool, | |||
|
|
|||
| // target ID for IME candidate. | |||
| #[cfg_attr(feature = "serde", serde(skip))] | |||
| pub(crate) ime_target_id: Id, | |||
There was a problem hiding this comment.
Won't this always be the same Id as the key used to find TextEditState?
There was a problem hiding this comment.
Yes, it only stores TextEdit ID.
It's currently working fine without any problems.
If something is wrong or needs to be fixed, please fix it or let me know.
There was a problem hiding this comment.
That the code is working fine is not enough. I need to maintain this, and so I need to understand it. Storing the Id here makes no sense to me, since it is already the key.
|
Blocked on #4358 |
|
for example, Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event::Ime#4358Fix: A symptom of characters being copied when there are multiple TextEdits.