Fix: On Windows, Strange IME display after update #4269 #4362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbasic
changed the title
emilk
reviewed
Apr 21, 2024
| let ime_rect_px = ime.rect * pixels_per_point; | ||
| let mut need_set_ime_cursor_area = true; | ||
|
|
||
| // On Wayland of Linux, repaints every frame Issue : See https://github.com/emilk/egui/pull/4254 |
There was a problem hiding this comment.
Since the problem occurs on Windows, we have moved it down to only apply on Linux.
emilk
reviewed
Apr 21, 2024
Comment on lines
+829
to
+830
| need_set_ime_cursor_area = self.ime_rect_px != Some(ime_rect_px) | ||
| && self.egui_ctx.input(|i| !i.events.is_empty()); |
There was a problem hiding this comment.
Do we need to treat Nix specially here? Isn't this logic sound for all OSes?
There was a problem hiding this comment.
I think it should only be applied on Linux.
Definitely shouldn't be applied on Windows.
Please check with emilk how to handle this on MacOs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: On windows, Strange IME display after update #4269